Add RSA_KEY_SIZE flag to cli test script #114
Merged
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gowthamsk-arm
force-pushed
the
override_keylen
branch
2 times, most recently
from
4340aab to
bbe12c8
Compare
|
I was wondering if we could start doing something like:
|
See for example: 2c78cc3 |
To be clearer, I'm talking about the commit message here. |
|
Sounds good. Will update the commit. |
gowthamsk-arm
force-pushed
the
override_keylen
branch
from
bbe12c8 to
4aeead4
Compare
tgonzalezorlandoarm
requested changes
Nov 23, 2023
| key_size=$1 | ||
| key_param="--bits $1" | ||
| else | ||
| key_size=${DEFAULT_SIZE} | ||
| key_size=2048 | ||
| key_param="" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Not a blocke but would it be worth to have a print-out of the chosen key size? Given that we have multiple ways of setting it RSA_KEY_SIZE enviroment var, --rsa-key-size or the default?
This flag can be used for testing parsec on slower platforms where RSA 2048 key operations are time consuming. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
override_keylen
branch
from
4aeead4 to
250350c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag can be used for testing parsec on slower platforms where RSA 2048 key operations are time consuming.
Closes #112
Signed-off-by: Gowtham Suresh Kumar [email protected]